Unifi-Voucher-Tool/admin/sites.php
Friederich Loheide f26684b128
All checks were successful
CI / PHP Lint (pull_request) Successful in 35s
CI / PHP Lint-1 (pull_request) Successful in 34s
CI / Unit Tests & Static Analysis (pull_request) Successful in 38s
CI / PHP Lint (push) Successful in 34s
CI / PHP Lint-1 (push) Successful in 32s
CI / Unit Tests & Static Analysis (push) Successful in 36s
Härtung: Backup vollständig, Caddy-Konfiguration, POST statt GET
Backup (das war eine echte Lücke): admin/backup.php sicherte nur
Einstellungen, Sites und Profile – die Display-Seiten fehlten. Nach einem
Restore wären alle Kiosk-Links weg gewesen und aufgehängte QR-Codes hätten
ins Leere gezeigt. Sie werden jetzt mitgesichert, inklusive Token, damit
vorhandene Aufkleber weiter funktionieren; Site und Profil werden über den
Namen verknüpft, weil die IDs auf der Zielinstallation andere sind.

Caddy: die mitgelieferte .htaccess wird von Caddy nicht gelesen – damit
griffen weder die Sicherheits-Header noch die Sperre, die PHP unterhalb
von uploads/ verbietet. docs/Caddyfile.example enthält beides, die README
verweist darauf.

Verändernde Aktionen laufen jetzt über POST statt über Links mit
CSRF-Token in der URL (Sites, Benutzer, Profile, API-Schlüssel, Display-
Seiten). Token in URLs landen in Server-Logs, Referer-Headern und der
Browser-Chronik. Neuer Helfer Ui::actionForm() hält das Markup kurz.

Entfernt: login_simple.php und m365_debug.php. login_simple.php war eine
zweite Login-Implementierung, die den Rückgabewert von Auth::login() als
Boolean behandelte – 'totp_required' und 'rate_limited' sind truthy, also
wurde auf index.php weitergeleitet, ohne dass eine Sitzung bestand. Kein
Bypass (setUserSession lief nicht), aber genau die Art Altlast, aus der
später einer wird.

Database::getInstance() bricht nicht mehr mit die() samt PDO-Meldung ab
(die Host und Datenbanknamen enthält), sondern zeigt im Web eine
schlichte 503-Seite und wirft auf der Kommandozeile weiter.

Neu: Warnung im Tab "Integration & Wartung", wenn eine Anfrage über einen
Proxy kam, aber kein vertrauenswürdiger Proxy eingetragen ist – dann
sehen Rate-Limit und Audit-Log für alle Gäste dieselbe IP.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-24 11:09:28 +00:00

313 lines
16 KiB
PHP
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

<?php
error_reporting(E_ALL);
ini_set('display_errors', 0);
ini_set('log_errors', 1);
require_once __DIR__ . '/../config.php';
require_once __DIR__ . '/../includes/Database.php';
require_once __DIR__ . '/../includes/Auth.php';
require_once __DIR__ . '/../includes/UniFiController.php';
require_once __DIR__ . '/../includes/I18n.php';
require_once __DIR__ . '/../includes/Ui.php';
$auth = new Auth();
$auth->requireAdmin();
$db = Database::getInstance();
$appTitle = $db->getSetting('app_title', 'UniFi Voucher System');
I18n::init();
$error = '';
$success = '';
// Edit site
if ($_SERVER['REQUEST_METHOD']==='POST' && isset($_POST['edit_site'])) {
if (!$auth->validateCsrfToken($_POST['csrf_token']??'')) {
$error = __('error_csrf');
} else {
try {
$siteId = (int)$_POST['site_id'];
$name = trim($_POST['name']);
$siteIdStr = trim($_POST['site_id_str']);
$controllerUrl = trim($_POST['controller_url']);
$username = trim($_POST['username']);
$password = $_POST['password'];
$publicAccess = isset($_POST['public_access']) ? 1 : 0;
if (empty($name)||empty($siteIdStr)||empty($controllerUrl)||empty($username)) throw new Exception(__('error_fill_all'));
if (!empty($password)) {
$test = UniFiController::testConnection($controllerUrl,$username,$password,$siteIdStr);
if ($test !== true) throw new Exception('Verbindung fehlgeschlagen: '.$test);
$db->execute("UPDATE sites SET name=?,site_id=?,unifi_controller_url=?,unifi_username=?,unifi_password=?,public_access=? WHERE id=?",
[$name,$siteIdStr,$controllerUrl,$username,Crypto::encrypt($password),$publicAccess,$siteId]);
} else {
$db->execute("UPDATE sites SET name=?,site_id=?,unifi_controller_url=?,unifi_username=?,public_access=? WHERE id=?",
[$name,$siteIdStr,$controllerUrl,$username,$publicAccess,$siteId]);
}
$auth->writeAuditLog($_SESSION['user_id'],'site_edit','site',$siteId,"Site {$name} aktualisiert");
$success = __('sites_updated');
} catch (Exception $e) { $error = $e->getMessage(); }
}
}
// Add site
if ($_SERVER['REQUEST_METHOD']==='POST' && isset($_POST['add_site'])) {
if (!$auth->validateCsrfToken($_POST['csrf_token']??'')) {
$error = __('error_csrf');
} else {
try {
$name = trim($_POST['name']);
$siteId = trim($_POST['site_id']);
$controllerUrl = trim($_POST['controller_url']);
$username = trim($_POST['username']);
$password = $_POST['password'];
$publicAccess = isset($_POST['public_access']) ? 1 : 0;
if (empty($name)||empty($siteId)||empty($controllerUrl)||empty($username)) throw new Exception(__('error_fill_all'));
$test = UniFiController::testConnection($controllerUrl,$username,$password,$siteId);
if ($test !== true) throw new Exception('Verbindung fehlgeschlagen: '.$test);
$newId = $db->execute("INSERT INTO sites (name,site_id,unifi_controller_url,unifi_username,unifi_password,public_access) VALUES (?,?,?,?,?,?)",
[$name,$siteId,$controllerUrl,$username,Crypto::encrypt($password),$publicAccess]);
$auth->writeAuditLog($_SESSION['user_id'],'site_create','site',$newId,"Site {$name} erstellt");
$success = __('sites_added');
} catch (Exception $e) { $error = $e->getMessage(); }
}
}
// Delete site
if ($_SERVER['REQUEST_METHOD'] === 'POST' && isset($_POST['delete_site'])) {
if ($auth->validateCsrfToken($_POST['csrf_token'] ?? '')) {
$delId = (int)($_POST['site_id'] ?? 0);
$db->query("DELETE FROM sites WHERE id=?", [$delId]);
$auth->writeAuditLog($_SESSION['user_id'],'site_delete','site',$delId,'Site gelöscht');
$success = __('sites_deleted');
} else { $error = __('error_csrf'); }
}
// Toggle site
if ($_SERVER['REQUEST_METHOD'] === 'POST' && isset($_POST['toggle_site'])) {
if ($auth->validateCsrfToken($_POST['csrf_token'] ?? '')) {
$site = $db->fetchOne("SELECT is_active FROM sites WHERE id=?", [(int)($_POST['site_id'] ?? 0)]);
if ($site) {
$db->query("UPDATE sites SET is_active=? WHERE id=?", [$site['is_active']?0:1,(int)($_POST['site_id'] ?? 0)]);
$success = 'Site-Status aktualisiert!';
}
} else { $error = __('error_csrf'); }
}
$sites = $db->fetchAll("SELECT * FROM sites ORDER BY name");
$currentPage = 'sites';
?>
<!DOCTYPE html>
<html lang="<?= I18n::getLanguage() ?>">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title><?= __('sites_title') ?> – <?= htmlspecialchars($appTitle) ?></title>
<?php include __DIR__ . '/../includes/admin_nav.php'; ?>
<div class="page-header">
<h1 class="page-title"><?= __('sites_title') ?></h1>
<button onclick="openModal()" class="btn btn-primary">
<i class="fas fa-plus" aria-hidden="true"></i> <?= __('sites_add') ?>
</button>
</div>
<?php if ($error): ?>
<div class="alert alert-error"><i class="fas fa-exclamation-circle" aria-hidden="true"></i> <?= htmlspecialchars($error) ?></div>
<?php endif; ?>
<?php if ($success): ?>
<div class="alert alert-success"><i class="fas fa-check-circle" aria-hidden="true"></i> <?= htmlspecialchars($success) ?></div>
<?php endif; ?>
<?php if (empty($sites)): ?>
<div class="empty-card">
<i class="fas fa-map-marker-alt" style="font-size:48px;margin-bottom:20px;opacity:.3;display:block;" aria-hidden="true"></i>
<p><?= __('sites_none') ?></p>
</div>
<?php else: ?>
<div class="sites-grid">
<?php foreach ($sites as $site): ?>
<div class="site-card">
<div class="site-card-header">
<div>
<div class="site-name"><?= htmlspecialchars($site['name']) ?></div>
<div class="site-id-label">ID: <?= htmlspecialchars($site['site_id']) ?></div>
</div>
<div>
<?php if ($site['is_active']): ?>
<span class="badge badge-success"><i class="fas fa-check" aria-hidden="true"></i> <?= __('status_active') ?></span>
<?php else: ?>
<span class="badge badge-warning"><i class="fas fa-pause" aria-hidden="true"></i> <?= __('status_inactive') ?></span>
<?php endif; ?>
<?php if ($site['public_access']): ?>
<span class="badge badge-info"><i class="fas fa-globe" aria-hidden="true"></i> <?= __('status_public') ?></span>
<?php endif; ?>
</div>
</div>
<div class="site-info">
<div class="site-info-item">
<i class="fas fa-server" style="color:var(--accent);width:16px;" aria-hidden="true"></i>
<span style="word-break:break-all;"><?= htmlspecialchars($site['unifi_controller_url']) ?></span>
</div>
<div class="site-info-item">
<i class="fas fa-user" style="color:var(--accent);width:16px;" aria-hidden="true"></i>
<span><?= htmlspecialchars($site['unifi_username']) ?></span>
</div>
<div class="site-info-item">
<i class="fas fa-clock" style="color:var(--text-muted);width:16px;" aria-hidden="true"></i>
<span style="color:var(--text-muted);"><?= date('d.m.Y', strtotime($site['created_at'])) ?></span>
</div>
</div>
<div class="site-actions">
<button onclick="openEditModal(<?= $site['id'] ?>, '<?= htmlspecialchars($site['name'], ENT_QUOTES) ?>', '<?= htmlspecialchars($site['site_id'], ENT_QUOTES) ?>', '<?= htmlspecialchars($site['unifi_controller_url'], ENT_QUOTES) ?>', '<?= htmlspecialchars($site['unifi_username'], ENT_QUOTES) ?>', <?= $site['public_access'] ?>)"
class="btn btn-secondary btn-sm">
<i class="fas fa-edit" aria-hidden="true"></i> <?= __('btn_edit') ?>
</button>
<?= Ui::actionForm('toggle_site', ['site_id' => $site['id']], $auth->getCsrfToken(),
'<i class="fas fa-' . ($site['is_active'] ? 'pause' : 'play') . '" aria-hidden="true"></i> '
. htmlspecialchars($site['is_active'] ? __('sites_deactivate') : __('sites_activate'))) ?>
<?= Ui::actionForm('delete_site', ['site_id' => $site['id']], $auth->getCsrfToken(),
'<i class="fas fa-trash" aria-hidden="true"></i>',
'btn btn-danger-soft btn-sm', __('js_confirm_delete_site'), __('btn_delete')) ?>
</div>
</div>
<?php endforeach; ?>
</div>
<?php endif; ?>
</main>
<!-- Add Site Modal -->
<div id="addSiteModal" class="modal">
<div class="modal-content">
<div class="modal-header">
<h2 class="modal-title"><?= __('sites_add_title') ?></h2>
<button class="modal-close" onclick="closeModal('addSiteModal')">&times;</button>
</div>
<div class="modal-body">
<form method="post" id="addSiteForm">
<input type="hidden" name="csrf_token" value="<?= $auth->getCsrfToken() ?>">
<input type="hidden" name="add_site" value="1">
<div class="form-group">
<label><?= __('sites_name') ?></label>
<input type="text" name="name" required placeholder="z.B. Hauptgebäude">
</div>
<div class="form-group">
<label><?= __('sites_site_id') ?></label>
<input type="text" name="site_id" required placeholder="z.B. default">
<small style="color:var(--text-muted);font-size:12px;"><?= __('sites_id_hint') ?></small>
</div>
<div class="form-group">
<label><?= __('sites_controller') ?></label>
<input type="url" name="controller_url" required placeholder="https://unifi.example.com:11443">
<small style="color:var(--text-muted);font-size:12px;">Vollständige URL inkl. Port</small>
</div>
<div class="form-grid">
<div class="form-group">
<label><?= __('sites_username') ?></label>
<input type="text" name="username" required placeholder="admin">
</div>
<div class="form-group">
<label><?= __('sites_password') ?></label>
<input type="password" name="password" required>
</div>
</div>
<div class="form-group checkbox-group">
<input type="checkbox" id="add_public" name="public_access">
<label for="add_public" style="margin:0;"><?= __('sites_public') ?></label>
</div>
<div style="display:flex;gap:10px;margin-top:20px;">
<button type="submit" class="btn btn-primary" style="flex:1;" id="addSiteSubmitBtn">
<i class="fas fa-save" aria-hidden="true"></i> <?= __('sites_add') ?>
</button>
<button type="button" onclick="closeModal('addSiteModal')" class="btn btn-secondary"><?= __('btn_cancel') ?></button>
</div>
</form>
</div>
</div>
</div>
<!-- Edit Site Modal -->
<div id="editSiteModal" class="modal">
<div class="modal-content">
<div class="modal-header">
<h2 class="modal-title"><?= __('sites_edit_title') ?></h2>
<button class="modal-close" onclick="closeModal('editSiteModal')">&times;</button>
</div>
<div class="modal-body">
<form method="post" id="editSiteForm">
<input type="hidden" name="csrf_token" value="<?= $auth->getCsrfToken() ?>">
<input type="hidden" name="edit_site" value="1">
<input type="hidden" name="site_id" id="edit_site_id">
<div class="form-group">
<label><?= __('sites_name') ?></label>
<input type="text" id="edit_name" name="name" required>
</div>
<div class="form-group">
<label><?= __('sites_site_id') ?></label>
<input type="text" id="edit_site_id_str" name="site_id_str" required>
</div>
<div class="form-group">
<label><?= __('sites_controller') ?></label>
<input type="url" id="edit_controller_url" name="controller_url" required>
</div>
<div class="form-grid">
<div class="form-group">
<label><?= __('sites_username') ?></label>
<input type="text" id="edit_username" name="username" required>
</div>
<div class="form-group">
<label><?= __('sites_password_edit') ?></label>
<input type="password" id="edit_password" name="password" placeholder="<?= __('sites_pw_unchanged') ?>">
<small style="color:var(--text-muted);font-size:12px;"><?= __('sites_password_hint') ?></small>
</div>
</div>
<div class="form-group checkbox-group">
<input type="checkbox" id="edit_public_access" name="public_access">
<label for="edit_public_access" style="margin:0;"><?= __('sites_public') ?></label>
</div>
<div style="display:flex;gap:10px;margin-top:20px;">
<button type="submit" class="btn btn-primary" style="flex:1;" id="editSiteSubmitBtn">
<i class="fas fa-save" aria-hidden="true"></i> <?= __('btn_save') ?>
</button>
<button type="button" onclick="closeModal('editSiteModal')" class="btn btn-secondary"><?= __('btn_cancel') ?></button>
</div>
</form>
</div>
</div>
</div>
<div id="toast-container" role="status" aria-live="polite"></div>
<script src="../assets/global.js"></script>
<script>
function openModal() { document.getElementById('addSiteModal').classList.add('active'); }
function closeModal(id) { document.getElementById(id).classList.remove('active'); }
function openEditModal(id, name, siteIdStr, controllerUrl, username, publicAccess) {
document.getElementById('edit_site_id').value = id;
document.getElementById('edit_name').value = name;
document.getElementById('edit_site_id_str').value = siteIdStr;
document.getElementById('edit_controller_url').value = controllerUrl;
document.getElementById('edit_username').value = username;
document.getElementById('edit_password').value = '';
document.getElementById('edit_public_access').checked = publicAccess == 1;
document.getElementById('editSiteModal').classList.add('active');
}
document.getElementById('addSiteForm').addEventListener('submit', function() {
const btn = document.getElementById('addSiteSubmitBtn');
btn.disabled = true;
btn.innerHTML = '<i class="fas fa-spinner fa-spin" aria-hidden="true"></i> <?= addslashes(__('sites_testing')) ?>';
});
document.getElementById('editSiteForm').addEventListener('submit', function() {
const btn = document.getElementById('editSiteSubmitBtn');
btn.disabled = true;
btn.innerHTML = '<i class="fas fa-spinner fa-spin" aria-hidden="true"></i> <?= addslashes(__('sites_testing')) ?>';
});
['addSiteModal','editSiteModal'].forEach(id => {
document.getElementById(id).addEventListener('click', function(e) {
if (e.target === this) closeModal(id);
});
});
</script>
</body>
</html>