Some checks failed
CI / PHP 8.3 / mariadb:10.6 (pull_request) Successful in 7m25s
CI / PHP 8.4 / mariadb:10.6 (pull_request) Successful in 6m46s
CI / PHP 8.3 / mariadb:11.4 (pull_request) Successful in 7m52s
CI / PHP 8.4 / mariadb:11.4 (pull_request) Successful in 8m5s
CI / PHP 8.3 / mysql:8.0 (pull_request) Failing after 10m33s
CI / PHP 8.4 / mysql:8.0 (pull_request) Failing after 10m53s
CI / PHP 8.3 / mysql:8.4 (pull_request) Failing after 9m1s
CI / PHP 8.4 / mysql:8.4 (pull_request) Failing after 8m49s
CI / Bekannte Sicherheitslücken in Paketen (pull_request) Successful in 54s
CI / Build-Artefakte aktuell (pull_request) Successful in 1m4s
- /uploads nur über das Portal: UploadController prüft Sitzung bzw. App-Token; frei nur die Dateien der Anmeldeseite (Logos, Symbole, Anmeldehintergrund, Stylesheet, Schrift); public/uploads/.htaccess leitet alles an index.php (Migration schreibt sie, da der Ordner vor dem Updater geschützt ist); Systemzustand prüft die Regel; nginx-Hinweis in docs/SECURITY.md - Passwort-Anmeldung abschaltbar (PasswordLogin): Login-Formular, Passwort vergessen, App-Token und /api/v1/config; nur mit verknüpftem Konto abschaltbar, automatische Rückkehr ohne nutzbaren Dienst, Notausgang INHAUS_PASSWORD_LOGIN - Titelbilder: profile_covers (bis 12), zufällig je Seitenaufruf - ImageCompressor: Uploads im Backend (SafeUpload) und WordPress-Import auf ≤ 2400 px komprimiert, Format bleibt Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
84 lines
3.8 KiB
PHP
84 lines
3.8 KiB
PHP
<?php
|
|
|
|
namespace Tests\Feature;
|
|
|
|
use App\Models\User;
|
|
use App\Support\Settings;
|
|
use App\Support\Theme\Theme;
|
|
use App\Support\UploadsGuard;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Http\UploadedFile;
|
|
use Illuminate\Support\Facades\Storage;
|
|
use Tests\TestCase;
|
|
|
|
class UploadsProtectionTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
parent::setUp();
|
|
|
|
Storage::fake('uploads');
|
|
$disk = Storage::disk('uploads');
|
|
$disk->put('news/bild.webp', UploadedFile::fake()->image('b.webp', 20, 20)->getContent());
|
|
$disk->put('theme/logo.png', UploadedFile::fake()->image('l.png', 20, 20)->getContent());
|
|
$disk->put('theme/login.jpg', UploadedFile::fake()->image('l.jpg', 20, 20)->getContent());
|
|
$disk->put('theme/cover.jpg', UploadedFile::fake()->image('c.jpg', 20, 20)->getContent());
|
|
$disk->put('theme/alt.png', UploadedFile::fake()->image('a.png', 20, 20)->getContent());
|
|
$disk->put('news/script.php', '<?php echo 1;');
|
|
|
|
app(Settings::class)->set('theme.published', [
|
|
...app(Theme::class)->published(),
|
|
'logo_light' => 'theme/logo.png', 'login_image' => 'theme/login.jpg', 'profile_cover' => 'theme/cover.jpg',
|
|
]);
|
|
}
|
|
|
|
public function test_files_need_a_login_except_what_the_login_page_needs(): void
|
|
{
|
|
// Ohne Anmeldung: nichts verraten
|
|
$this->get('/uploads/news/bild.webp')->assertNotFound();
|
|
$this->get('/uploads/theme/cover.jpg')->assertNotFound();
|
|
$this->get('/uploads/theme/alt.png')->assertNotFound(); // nicht (mehr) im Erscheinungsbild
|
|
|
|
// Anmeldeseite: Logo und Hintergrund frei, öffentlich zwischenspeicherbar
|
|
$logo = $this->get('/uploads/theme/logo.png')->assertOk();
|
|
$this->assertStringContainsString('public', $logo->headers->get('Cache-Control'));
|
|
$this->assertSame('nosniff', $logo->headers->get('X-Content-Type-Options'));
|
|
$this->get('/uploads/theme/login.jpg')->assertOk();
|
|
|
|
// Angemeldet: alles, aber nur privat zwischengespeichert
|
|
$user = User::factory()->create();
|
|
$response = $this->actingAs($user)->get('/uploads/news/bild.webp')->assertOk();
|
|
$this->assertStringContainsString('private', $response->headers->get('Cache-Control'));
|
|
$this->assertSame('image/webp', $response->headers->get('Content-Type'));
|
|
$this->actingAs($user)->get('/uploads/theme/cover.jpg')->assertOk();
|
|
|
|
// Nie: fremde Dateitypen, Pfade nach draußen
|
|
$this->actingAs($user)->get('/uploads/news/script.php')->assertNotFound();
|
|
$this->actingAs($user)->get('/uploads/../.env')->assertNotFound();
|
|
$this->actingAs($user)->get('/uploads/news/..%2F..%2F.env')->assertNotFound();
|
|
$this->actingAs($user)->get('/uploads/news/fehlt.webp')->assertNotFound();
|
|
}
|
|
|
|
public function test_app_token_and_deactivated_accounts(): void
|
|
{
|
|
$user = User::factory()->create();
|
|
$token = $user->createToken('App')->plainTextToken;
|
|
$this->withToken($token)->get('/uploads/news/bild.webp')->assertOk();
|
|
|
|
$this->app['auth']->forgetGuards();
|
|
$user->forceFill(['is_active' => false])->save();
|
|
$this->withToken($token)->get('/uploads/news/bild.webp')->assertNotFound();
|
|
}
|
|
|
|
public function test_guard_file_is_written(): void
|
|
{
|
|
$dir = sys_get_temp_dir().'/inhaus-uploads-'.bin2hex(random_bytes(4));
|
|
$this->assertFalse(UploadsGuard::installed($dir));
|
|
$this->assertTrue(UploadsGuard::install($dir));
|
|
$this->assertTrue(UploadsGuard::installed($dir));
|
|
$this->assertStringContainsString('RewriteRule ^ ../index.php [L]', file_get_contents($dir.'/.htaccess'));
|
|
$this->assertStringContainsString('Require all denied', file_get_contents($dir.'/.htaccess'));
|
|
}
|
|
}
|