Sicherheitsupdate nach Audit (0.29.0)
Some checks failed
CI / PHP 8.3 / mariadb:10.6 (pull_request) Successful in 7m50s
CI / PHP 8.4 / mariadb:10.6 (pull_request) Successful in 7m34s
CI / PHP 8.3 / mariadb:11.4 (pull_request) Successful in 5m45s
CI / PHP 8.4 / mariadb:11.4 (pull_request) Successful in 5m30s
CI / PHP 8.3 / mysql:8.0 (pull_request) Failing after 7m7s
CI / PHP 8.4 / mysql:8.0 (pull_request) Failing after 7m9s
CI / PHP 8.3 / mysql:8.4 (pull_request) Failing after 6m8s
CI / PHP 8.4 / mysql:8.4 (pull_request) Failing after 6m5s
CI / Bekannte Sicherheitslücken in Paketen (pull_request) Successful in 48s
CI / Build-Artefakte aktuell (pull_request) Successful in 1m5s
Some checks failed
CI / PHP 8.3 / mariadb:10.6 (pull_request) Successful in 7m50s
CI / PHP 8.4 / mariadb:10.6 (pull_request) Successful in 7m34s
CI / PHP 8.3 / mariadb:11.4 (pull_request) Successful in 5m45s
CI / PHP 8.4 / mariadb:11.4 (pull_request) Successful in 5m30s
CI / PHP 8.3 / mysql:8.0 (pull_request) Failing after 7m7s
CI / PHP 8.4 / mysql:8.0 (pull_request) Failing after 7m9s
CI / PHP 8.3 / mysql:8.4 (pull_request) Failing after 6m8s
CI / PHP 8.4 / mysql:8.4 (pull_request) Failing after 6m5s
CI / Bekannte Sicherheitslücken in Paketen (pull_request) Successful in 48s
CI / Build-Artefakte aktuell (pull_request) Successful in 1m5s
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
a37895a16a
commit
f1202bea08
226 changed files with 1952 additions and 450 deletions
|
|
@ -4,10 +4,13 @@ namespace App\Http\Controllers\Api;
|
|||
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Models\User;
|
||||
use App\Providers\FortifyServiceProvider;
|
||||
use App\Support\Audit;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
use Illuminate\Http\Request;
|
||||
use Illuminate\Support\Facades\Hash;
|
||||
use Illuminate\Support\Facades\RateLimiter;
|
||||
use Illuminate\Support\Str;
|
||||
use Illuminate\Validation\ValidationException;
|
||||
|
||||
class AuthController extends Controller
|
||||
|
|
@ -24,12 +27,31 @@ class AuthController extends Controller
|
|||
'device_name' => ['required', 'string', 'max:100'],
|
||||
]);
|
||||
|
||||
$user = User::query()->where('email', $data['email'])->first();
|
||||
// Je E-Mail-Adresse begrenzen (zusätzlich zur Begrenzung je IP) – gegen Durchprobieren von Passwörtern
|
||||
$key = 'api-token:'.Str::lower($data['email']);
|
||||
|
||||
if (RateLimiter::tooManyAttempts($key, 5)) {
|
||||
throw ValidationException::withMessages(['email' => 'Zu viele Versuche. Bitte in einigen Minuten erneut versuchen.']);
|
||||
}
|
||||
|
||||
$user = User::query()->where('email', Str::lower($data['email']))->first();
|
||||
$valid = Hash::check($data['password'], $user?->password ?? FortifyServiceProvider::dummyHash());
|
||||
|
||||
if (! $user || ! $user->is_active || $user->password === null || ! $valid) {
|
||||
RateLimiter::hit($key, 300);
|
||||
|
||||
if (! $user || ! $user->is_active || $user->password === null || ! Hash::check($data['password'], $user->password)) {
|
||||
throw ValidationException::withMessages(['email' => 'Diese Kombination aus Zugangsdaten wurde nicht gefunden.']);
|
||||
}
|
||||
|
||||
RateLimiter::clear($key);
|
||||
|
||||
// Höchstens 20 Zugänge je Person – der älteste fällt weg
|
||||
$excess = $user->tokens()->count() - 19;
|
||||
|
||||
if ($excess > 0) {
|
||||
$user->tokens()->oldest()->limit($excess)->get()->each->delete();
|
||||
}
|
||||
|
||||
$token = $user->createToken(trim($data['device_name']));
|
||||
Audit::log('api.token_created', ['user' => $user->id, 'device' => $data['device_name']]);
|
||||
|
||||
|
|
|
|||
|
|
@ -38,7 +38,9 @@ class NotificationController extends Controller
|
|||
$url = (string) ($notification->data['url'] ?? '');
|
||||
|
||||
// Nur Adressen innerhalb des Portals ansteuern.
|
||||
return redirect()->to($url !== '' && (Str::startsWith($url, '/') && ! Str::startsWith($url, '//') || Str::startsWith($url, url('/'))) ? $url : '/');
|
||||
$local = preg_match('#^/(?![/\\\\])#', $url) || Str::startsWith($url, url('/').'/');
|
||||
|
||||
return redirect()->to($local ? $url : '/');
|
||||
}
|
||||
|
||||
public function markAllRead(Request $request): JsonResponse
|
||||
|
|
|
|||
|
|
@ -8,6 +8,8 @@ use App\Profile\ProfileSections;
|
|||
use App\Support\Audit;
|
||||
use App\Support\Avatars;
|
||||
use App\Support\Covers;
|
||||
use App\Support\ImageTooLarge;
|
||||
use App\Support\Impersonation;
|
||||
use App\Support\ProfileFields;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
use Illuminate\Http\RedirectResponse;
|
||||
|
|
@ -30,6 +32,7 @@ class ProfileController extends Controller
|
|||
{
|
||||
$user = $request->user();
|
||||
$managed = $user->managedFields();
|
||||
$locked = $user->lockedProfileFields();
|
||||
|
||||
return Inertia::render('Profile/Edit', [
|
||||
'profile' => [
|
||||
|
|
@ -45,6 +48,8 @@ class ProfileController extends Controller
|
|||
],
|
||||
// Felder, die Microsoft Entra ID pflegt – im Portal nur lesbar.
|
||||
'managed' => $managed,
|
||||
// Nicht selbst änderbar (E-Mail, ggf. Abteilung/Standort): pflegt die Personalverwaltung
|
||||
'locked' => $locked,
|
||||
'customFields' => $profileFields->formFor($user, $managed),
|
||||
'sections' => app(ProfileSections::class)->resolve($user),
|
||||
// Apps & Geräte: persönliche Zugangs-Tokens für die REST-API
|
||||
|
|
@ -60,7 +65,7 @@ class ProfileController extends Controller
|
|||
public function update(UpdateProfileRequest $request, ProfileFields $profileFields): RedirectResponse
|
||||
{
|
||||
$user = $request->user();
|
||||
$managed = $user->managedFields();
|
||||
$managed = $user->lockedProfileFields();
|
||||
$user->update(collect($request->validated())->except([...$managed, 'custom_fields'])->all());
|
||||
|
||||
if ($request->has('custom_fields')) {
|
||||
|
|
@ -78,6 +83,8 @@ class ProfileController extends Controller
|
|||
|
||||
try {
|
||||
$avatars->store($request->user(), $request->file('avatar'));
|
||||
} catch (ImageTooLarge $e) {
|
||||
throw ValidationException::withMessages(['avatar' => $e->getMessage()]);
|
||||
} catch (Throwable $e) {
|
||||
// Meist eine Server-Einschränkung (GD ohne WebP, Upload-Ordner schreibgeschützt,
|
||||
// zu wenig Speicher) – verständliche Meldung statt „500 Interner Fehler“.
|
||||
|
|
@ -105,6 +112,8 @@ class ProfileController extends Controller
|
|||
|
||||
public function createToken(Request $request): JsonResponse
|
||||
{
|
||||
// Während „Als Person anmelden“ keine dauerhaften Zugänge für die andere Person
|
||||
abort_if(app(Impersonation::class)->active(), 403, 'Während „Als Person anmelden“ können keine App-Zugänge angelegt werden.');
|
||||
$data = $request->validate(['name' => ['required', 'string', 'max:100']], [], ['name' => 'Name']);
|
||||
abort_if($request->user()->tokens()->count() >= 20, 422, 'Höchstens 20 Apps und Geräte – bitte alte entfernen.');
|
||||
|
||||
|
|
@ -129,6 +138,8 @@ class ProfileController extends Controller
|
|||
|
||||
try {
|
||||
$covers->store($request->user(), $request->file('cover'));
|
||||
} catch (ImageTooLarge $e) {
|
||||
throw ValidationException::withMessages(['cover' => $e->getMessage()]);
|
||||
} catch (Throwable $e) {
|
||||
report($e);
|
||||
|
||||
|
|
|
|||
|
|
@ -23,8 +23,17 @@ class PushController extends Controller
|
|||
'keys.auth' => ['required', 'string', 'max:40'],
|
||||
]);
|
||||
|
||||
abort_unless(WebPush::isAllowedEndpoint($data['endpoint']), 422, 'Dieser Push-Dienst wird nicht unterstützt.');
|
||||
|
||||
$hash = hash('sha256', $data['endpoint']);
|
||||
$existing = PushSubscription::query()->where('endpoint_hash', $hash)->first();
|
||||
|
||||
// Fremde Abonnements nicht übernehmen; höchstens 10 Geräte je Person
|
||||
abort_if($existing && $existing->user_id !== $request->user()->id, 409, 'Dieses Gerät ist einer anderen Person zugeordnet.');
|
||||
abort_if(! $existing && PushSubscription::query()->where('user_id', $request->user()->id)->count() >= 10, 422, 'Höchstens 10 Geräte – bitte Push auf einem alten Gerät ausschalten.');
|
||||
|
||||
PushSubscription::query()->updateOrCreate(
|
||||
['endpoint_hash' => hash('sha256', $data['endpoint'])],
|
||||
['endpoint_hash' => $hash],
|
||||
[
|
||||
'user_id' => $request->user()->id,
|
||||
'endpoint' => $data['endpoint'],
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue